Skip to content

CHEF-5815: Update signing method for msi packages (uses smctl now)#246

Open
ahasunos wants to merge 13 commits intomainfrom
ss/update-signing-identity-method-omnibus-toolchain
Open

CHEF-5815: Update signing method for msi packages (uses smctl now)#246
ahasunos wants to merge 13 commits intomainfrom
ss/update-signing-identity-method-omnibus-toolchain

Conversation

@ahasunos
Copy link

@ahasunos ahasunos commented Sep 14, 2023

Description

This PR updates the signing_identity invocation with the latest required parameters as per the smctl signing tool introduced in omnibus.

Related Issue

CHEF-5815: Digicert - renew license and implement HSM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…_alias

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos requested review from a team as code owners September 14, 2023 15:27
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos force-pushed the ss/update-signing-identity-method-omnibus-toolchain branch from c966ea1 to 334100c Compare September 14, 2023 15:44
dependabot bot and others added 3 commits September 25, 2023 13:34
Bumps [omnibus](https://github.com/chef/omnibus) from `d6d4b0d` to `56015cb`.
- [Release notes](https://github.com/chef/omnibus/releases)
- [Commits](chef/omnibus@d6d4b0d...56015cb)

---
updated-dependencies:
- dependency-name: omnibus
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Obvious fix; these changes are the result of automation not creative thinking.
ahasunos and others added 4 commits October 2, 2023 19:15
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
Signed-off-by: Sean Simmons <ssimmons@progress.com>
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sean-sype-simmons sean-sype-simmons requested a review from a team as a code owner October 3, 2023 11:43
Signed-off-by: Sean Simmons <ssimmons@progress.com>
Signed-off-by: Sean Simmons <ssimmons@progress.com>
Signed-off-by: Sean Simmons <ssimmons@progress.com>
Signed-off-by: Sean Simmons <ssimmons@progress.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sean-sype-simmons
Copy link
Contributor

sean-sype-simmons commented Oct 5, 2023

we should clean this up, and then we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants